Error in JAVA creation of arrayList incompatible types: String can not be converted to branch ----

As the other user told you, your mistake is that in the constructor you declared a parameter as a branch (which by custom should be capitalized because it is a class).

  

new advisor = new advisor (IDAS2, NOM1, DIR1, SUC1, EMA1, NUMC2, EDA2);

Where it says SUC1 , you should be receiving a branch object (new branch ()), however you're passing it a SUC1 that belongs to the String .

How do you fix it?

a) Changing the type of the constructor parameter to a String.

b) Changing what you say in the advisor, and instead of SUC1 you put new branch () . (Only it will throw you an error in some lines that you have used methods that depend on String )

In conclusion, if you do not have a lot of experience in java, I would tell you to change the constructor to String and that from a short while you can see the different customs that are used.

============= Annex: Points to consider =============

Since there are some things that I saw in your questions are loose I'll leave you the three classes, the copies in their respective classes and you give Run as java application in BancoController strong>.

This is not right since I am expanding in my answer but you see a complete example. I did not solve what you have in the Button because it is something you have to process yourself, surely calling the name of the bank as indicated in the example.

Class Branch

public class Sucursal {

    private int id;
    private String nombreSucursal;
    private String direccionSucursal;
    private int telefono;
    private String localidad;

    public Sucursal() {
        // TODO Auto-generated constructor stub
    }

    public int getId() {
        return id;
    }

    public void setId(int id) {
        this.id = id;
    }

    public String getNombreSucursal() {
        return nombreSucursal;
    }

    public void setNombreSucursal(String nombreSucursal) {
        this.nombreSucursal = nombreSucursal;
    }

    public String getDireccionSucursal() {
        return direccionSucursal;
    }

    public void setDireccionSucursal(String direccionSucursal) {
        this.direccionSucursal = direccionSucursal;
    }

    public int getTelefono() {
        return telefono;
    }

    public void setTelefono(int telefono) {
        this.telefono = telefono;
    }

    public String getLocalidad() {
        return localidad;
    }

    public void setLocalidad(String localidad) {
        this.localidad = localidad;
    }

}

Class Advisor

public class Asesor {

    private int id;
    private Sucursal Sucursal;
    private String nombre;
    private String direccion;
    private String email;
    private int telefono;
    private int edad;

    public Asesor(int id, Sucursal sucursal, String nombre, String direccion, String email, int telefono,
            int edad) {
        super();
        this.id = id;
        Sucursal = sucursal;
        this.nombre = nombre;
        this.direccion = direccion;
        this.email = email;
        this.telefono = telefono;
        this.edad = edad;
    }

    public int getId() {
        return id;
    }
    public void setId(int id) {
        this.id = id;
    }
    public Sucursal getSucursal() {
        return Sucursal;
    }
    public void setSucursal(Sucursal sucursal) {
        Sucursal = sucursal;
    }
    public String getEmail() {
        return email;
    }
    public void setEmail(String email) {
        this.email = email;
    }
    public int getTelefono() {
        return telefono;
    }
    public void setTelefono(int telefono) {
        this.telefono = telefono;
    }
    public int getEdad() {
        return edad;
    }
    public void setEdad(int edad) {
        this.edad = edad;
    }
    public String getNombre() {
        return nombre;
    }
    public void setNombre(String nombre) {
        this.nombre = nombre;
    }
    public String getDireccion() {
        return direccion;
    }
    public void setDireccion(String direccion) {
        this.direccion = direccion;
    }

}

Class BankController

public class BancoControlador {

    public BancoControlador() {

        /* Creamos la sucursal que le vamos a pasar por parámetro al Asesor */
        Sucursal sucursal = new Sucursal();
        sucursal.setDireccionSucursal("Dirección de la misma");
        sucursal.setLocalidad("blabla");
        sucursal.setNombreSucursal("Sucursal1");

        /* Acá creamos el arrayList que no entiendo para qué lo necesitás, osea donde la vas a usar, sin embargo te digo que podés cargar varios objetos de Sucursal e iterar sobre los mismos */
        ArrayList<Sucursal> listadoSucursales = new ArrayList<>();
        listadoSucursales.add(sucursal);

        /* Le pasamos por parámetro la sucursal que acabamos de crear */
        Asesor asesor = new Asesor(1, sucursal, "Armando", "Springfield 252", "[email protected]", 1551112535, 21);

        /*
         * Como ejemplo nomás ponemos dentro del constructor el método que llama al
         * objeto Sucursal que a su vez tiene sus atributos como nombre direccion etc,
         */

        System.out.println(asesor.getSucursal().getNombreSucursal());

        /*
         * Fijate que hay un método que llama a la sucursal que le pasamos de parámetro
         * y otra que llama al nombre de ésa sucursal
         */
    }

    public static void main(String[] args) {
        /*
         * Creamos una instancia de esta misma clase y le damos Run as java application
         */
        BancoControlador bc = new BancoControlador();

    }

}

1) Note that in the variables camelCase is used, it starts with lowercase and there are separations with capitals, do not use underscore to name variables.

2) Classes should always start with capital letters, like constructors if they exist.

In your advisor builder the fourth parameter is a branch

public asesor(int IDASESOR_, String Nombre_asesor_, String Direccion_, sucursal Sucursal_, String email_, int num_cel_, int edad_)

You are sending him a String

  asesor nuevo = new asesor(IDAS2, NOM1, DIR1, SUC1, EMA1, NUMC2, EDA2);

String SUC1=SUC.getText(); // cuarto parametro es String

As a tip, have good practices, the classes go with UpperCamelCase and the variables with lowCamelCase.

Ok guys I understand your answers, but you have not understood me, what I need is to instantiate both classes, calling the branch class in the advisory class