Error with foreach and cartesian product

Question

Error with foreach and cartesian product

Navigation

#1 by (1 votes)

0

I have this code:

$CArticulos = Consulta_Dinamica("Array","*","Articulos","'borrado' != 1 ORDER BY 'id' DESC");
    if ($CArticulos) { //si existen Datos en la base de datos

foreach($CArticulos as $DArticulos) {

if (isset($DArticulos['talla'])) { $taLlas = explode(",", $DArticulos['talla']); } else { $tallas=""; }
if (isset($DArticulos['color'])) { $coLores = explode(",", $DArticulos['color']); } else { $colores=""; }

$UpTallicolor = CartesianProduct(array('tallas'=> $taLlas, 'color'=> $coLores));
foreach($UpTallicolor as $DUptallicolor) {
    $CExisteArt = Consulta_Dinamica("Simple","*","Test","'que' = 'Codigo' AND 'idcosa' = '".$DArticulos["id"]."' AND 'Dc1'='".$DUptallicolor['tallas']."' AND 'Dc2'='".$DUptallicolor['color']."' ");
    if ($CExisteArt) { echo "existe"; } else { echo "no existe";
        $CCodEan = Consulta_Dinamica("Simple","*","Configuraciones","'Conf_que' = 'Codigos' AND 'Conf1' = '".$_SESSION['Empresa_Pais']."' ");
        $Eanmin = $CCodEan["Conf2"].$CCodEan["Conf3"].$CCodEan["Conf4"]; $Eanmax = $CCodEan["Conf2"].$CCodEan["Conf3"].$CCodEan["Conf5"];

        $CeanLibre = "SELECT MIN(t1.'Dc3')+1 as prox_ean_libre FROM 'Test' t1 LEFT JOIN 'Test' t2 ON t2.'Dc3'=(t1.'Dc3')+1 AND t2.'Dc3' BETWEEN '".$Eanmin."' AND '".$Eanmax."' WHERE t1.'Dc3' BETWEEN '".$Eanmin."' AND '".$Eanmax."' AND t2.'Dc3' IS NULL"; //miramos de nuevo el ultimo codigo por si aca
        $REanLibre = mysqli_query($Conectar ,$CeanLibre); $DEanLibre=mysqli_fetch_array($REanLibre);
        if (empty($DEanLibre["prox_ean_libre"])) { $Eanlibre = $Eanmin; } else { $Eanlibre = $DEanLibre["prox_ean_libre"]; }
        $UpdTallicolor = Insertar_Datos("Test" , "'que','idcosa','Dc1','Dc2','Dc3'" , "'Codigo','".$DArticulos["id"]."','".$DUptallicolor['tallas']."','".$DUptallicolor['color']."','".$Eanlibre."' "); } //si no existe ese articulo en los codigos
        mysqli_free_result($REanLibre);
} //cierro el foreach

What it does is read the mysql articles table, it generates an array with sizes and another with colors that executes another loop with a cartesian product to assign ean codes to each cartesian product, in which I look at what is previously free. The fact is that if you have few records, it works fine, but at the moment there are enough (about 100) it is slow to the point that it gives a waiting time error and does not save anything.

Is there a way to optimize it or make it run bit by bit (with each loop you save in mysql)?

the code to generate the Cartesian product is this:

function CartesianProduct($sets) {
    $cartesian = array();
    foreach ($sets as $key => $set) { if (empty($set)) { continue; } // Si un grupo esta vació no afecta el producto cartesiano
    if (empty($cartesian)) { $cartesian[] = array(); }// Si esta vacio agregamos el primer grupo
    $subset = array();
    foreach ($cartesian as $product) {
        foreach($set as $value) {
            $product[$key] = $value;
            $subset[] = $product;
        }
    }
$cartesian = $subset;
    }
return $cartesian;
}

the array that the cartesian product of a single article generates is this:

the array that generates the response code is this:

Array ( [0] => Array ( [tallas] => 60 ) [1] => Array ( [tallas] => 61 ) [2] => Array ( [tallas] => 62 ) [3] => Array ( [tallas] => 63 ) [4] => Array ( [tallas] => 64 ) [5] => Array ( [tallas] => 65 ) [6] => Array ( [tallas] => 66 ) [7] => Array ( [tallas] => 67 ) [8] => Array ( [tallas] => 67 [color] => 250 ) [9] => Array ( [tallas] => 67 [color] => 252 ) [10] => Array ( [tallas] => 67 [color] => 185 ) [11] => Array ( [tallas] => 67 [color] => 158 ) [12] => Array ( [tallas] => 67 [color] => 183 ) [13] => Array ( [tallas] => 67 [color] => 106 ) [14] => Array ( [tallas] => 67 [color] => 198 ) [15] => Array ( [tallas] => 67 [color] => 181 ) [16] => Array ( [tallas] => 67 [color] => 72 ) [17] => Array ( [tallas] => 67 [color] => 178 ) [18] => Array ( [tallas] => 67 [color] => 184 ) [19] => Array ( [tallas] => 67 [color] => 180 ) [20] => Array ( [tallas] => 67 [color] => 196 ) [21] => Array ( [tallas] => 67 [color] => 147 ) [22] => Array ( [tallas] => 67 [color] => 116 ) [23] => Array ( [tallas] => 67 [color] => 166 ) [24] => Array ( [tallas] => 67 [color] => 165 ) [25] => Array ( [tallas] => 67 [color] => 179 ) [26] => Array ( [tallas] => 67 [color] => 151 ) [27] => Array ( [tallas] => 67 [color] => 197 ) [28] => Array ( [tallas] => 67 [color] => 195 ) [29] => Array ( [tallas] => 67 [color] => 177 ) )

mysql php

asked by Killpe 15.10.2017 в 22:49

source

1 answer

Show gif loading php How to compare a variable with a string in Shell Script?

score 1 · Answer 1

I was looking more closely at your code. You may have multiple errors in the logic of the program, and without getting into BD design.

Try changing your CartesianProduct function for this one at the moment, to see if it keeps working:

function CartesianProduct( $arr_sets ) {

    if ( ! $arr_sets || ! is_array( $arr_sets ))
        return FALSE;


    $product   = array();
    $cartesian = array();
    foreach ( $arr_sets as $key => $set ) {

        if ( $set && is_array( $set )) { 

            foreach( $set as $value ) {

                $product[ $key ] = $value;
                $cartesian[] = $product;
            }
        }
    }


    return $cartesian;
}

** ==================

I add content: **

It is smaller and changes the way of interpreting it, what I do not know if he has all the data. I can not prove it. Tea explain in steps what changes.

/*** Código original ***/
function CartesianProduct( $arr_sets ) {

    $cartesian = array();
    foreach ( $arr_sets as $key => $set ) { 

        if ( empty( $set )) { 
            continue; 
        } // Si un grupo esta vació no afecta el producto cartesiano

        if ( empty( $cartesian )) { 
            $cartesian[] = array(); 
        }// Si esta vacio agregamos el primer grupo

        $subset = array();
        foreach ( $cartesian as $product ) {

            foreach( $set as $value ) {

                $product[ $key ] = $value;
                $subset[] = $product;
            }
        }

        $cartesian = $subset;
    }

    return $cartesian;
}


/**
 * 1. Esto generaría el mismo array que tu código
 * 
 * Inicializo todos los arrays que vamos a utilizar fuera del foreach principal
 * Elimino tus dos primeros bloques condicionales:
 *   "if (empty($set)) { continue; }" lo sustituyo incluyendo todo en el condicional:
 *   "if ( $set && is_array( $set )) { ... }" incluyendo el código subsiguiente 
 *   dentro "if (empty($cartesian)) { $cartesian[] = array(); }" lo sustituyo por 
 *   
 *   "$cartesian[] = array();" antes del foreach, entiendo que esto se hace en
 *   la primera iteración del foreach porque $cartesian, recien declarado es un 
 *   array vacio siempre
 * 
 */
function CartesianProduct( $arr_sets ) {

    if ( ! $arr_sets || ! is_array( $arr_sets ))
        return FALSE;

    $cartesian = array();
    $subset    = array();
    $cartesian[] = array();
    foreach ($arr_sets as $key => $set) {

        if ( $set && is_array( $set )) {

            foreach ($cartesian as $product) {

                foreach($set as $value) {

                    $product[$key] = $value;
                    $subset[] = $product;
                }
            }

            $cartesian = $subset; 
        }
    }


    return $cartesian;
}

/**
 * 2. Mismo código, con una clausula de salvaguarda al comienzo y comentarios. La salida debería seguir siendo la misma que tienes
 * 
 */
function CartesianProduct( $arr_sets ) {

    /**
     * Clausula de salvaguarda
     * 
     * Evita error si la función no recibe un array y que se siga ejecutando 
     * el resto del código, evitando añadir un nivel de indentado
     */
    if ( ! $arr_sets || ! is_array( $arr_sets ))
        return FALSE;

    /**
     * Inicializa los arrays que se usarán
     *
     */
    $cartesian = array();
    $subset    = array();
    $cartesian[] = array();
    foreach ( $arr_sets as $key => $set ) {

        //Este condicional actua como la clausula de salvaguarda, pero no
        //finaliza la ejcución ni evita un nivel de indentado, incluye todo 
        //lo que se va a enecutar en la interacción en su interior
        if ( $set && is_array( $set )) {

            foreach ($cartesian as $product) {

                foreach($set as $value) {

                    $product[$key] = $value;
                    $subset[] = $product;
                }
            }

            $cartesian = $subset; 
        }
    }


    return $cartesian;
}

/**
 * 3. Simplificando. Esto cambia la salida
 * 
 * Pongo sólo la parte de código que queda por cambiar
 */
$cartesian = array();
$subset    = array();
//$cartesian[] = array();
foreach ( $arr_sets as $key => $set ) {

    //Este condicional actua como la clausula de salvaguarda, pero no
    //finaliza la ejcución ni evita un nivel de indentado, incluye todo 
    //lo que se va a enecutar en la interacción en su interior
    if ( $set && is_array( $set )) {

        /**
         * Este foreach sobra, se debería ejecutar una sola vez, solo 
         * tiene un array vacio en la primera posición
         * 
         * Una declaración previa de "$product = array();" reemplazaría 
         * a "$cartesian[] = array();" y permite eliminar este "foreach"
         */
        //foreach ($cartesian as $product) {

            foreach( $set as $value ) {

                $product[ $key ] = $value;
                $subset[] = $product;
            }
        //}

        $cartesian = $subset; 
    }
}

/**
 * 4. Simplificando. Esto cambia la salida
 * 
 * Pongo sólo la parte de código que queda por cambiar
 * 
 * El array "subset" ya no es necesario, empleo a "cartesian" en su lugar
 */
$cartesian = array();
$product   = array();
foreach ( $arr_sets as $key => $set ) {

    if ( $set && is_array( $set )) {

        foreach( $set as $value ) {

            $product[ $key ] = $value;
            $cartesian[] = $product;
        }
    }
}